Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to upload xcode archive to s3 #45

Merged
merged 4 commits into from
Nov 22, 2017

Conversation

claireduf
Copy link
Contributor

First thank you so much for this plugin, it is so useful!
I need to upload xcode archive instead of .ipa, to be more precise I want to send someone an app he has to re-sign and it is easier to re-sign an archive instead of an .ipa.
I add a method to upload archive provided with parameter :archive, this parameter is optional and do not change other features.

@joshdholtz
Copy link
Member

@claireAD This is fantastic! Going to merge this and will get a new version released this week 😊

@joshdholtz joshdholtz merged commit 9074616 into fastlane-community:master Nov 22, 2017
@davibe
Copy link

davibe commented Nov 28, 2017

Something like artifacts: "path/to/folder" that uploads everything to [buildName]/[platform]/artifacts ?

An array of files is rather boring for example if you want to upload a webpage with the changelog + autogenerated pages with test results

@claireduf
Copy link
Contributor Author

Hi @joshdholtz
do you plan to do a release soon? it would be great if this change could be merged
thanks a lot!

@acecilia
Copy link

Hi @claireduf:
Just updated from 1.1.1 to 1.4.0, and realized that the archive is being uploaded to S3 without me specifying it in the parameters.

How can I avoid the upload of the archive? Zipping and uploading it takes considerable time.

Thanks!

@claireduf
Copy link
Contributor Author

Hi @acecilia
if I add a parameter skip_xcarchive_upload to avoid uploading xcarchive, would it be fine?

@acecilia
Copy link

acecilia commented Apr 26, 2018

@claireduf I would go for:

  • Having the xcarchive parameter, in order to pass the path to the archive.
  • Only upload the archive if the xcarchive parameter has been assigned a value.
  • Have a reserved string (for example "default_path" or "obtain_path_from_gym") to pass to the xcarchive parameter, to indicate that we want to upload the archive using the path coming from gym, instead of an absolute one.

It seems more correct to me to upload the archive if it is requested by the user in the parameters, than upload the archive by default without any request form the user. Zipping and uploading the archive takes a considerable time (in my case, doing this makes the S3 step longer than what gym takes to build my hole app)

@claireduf
Copy link
Contributor Author

@acecilia
I just open a pull request to do this

thanks for your feedback

jaximan pushed a commit to jaximan/fastlane-plugin-s3 that referenced this pull request Jun 26, 2019
* Add method to upload xcarchive

* Use default value from gym for archive path

* Change version number

* Minor change to comply with files which are not in project directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants