Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add benchmark PR workflow #408

Closed

Conversation

mweberxyz
Copy link
Contributor

@mweberxyz mweberxyz commented Feb 19, 2024

Adds the shared plugins-benchmark-pr.yml workflow to PRs.

Usage

Add the benchmark tag to a PR in order to run benchmarks and compare against master.

Example

mweberxyz#2

Checklist

@mweberxyz mweberxyz changed the title chore: add benchmark PR workflow - Test in Fork chore: add benchmark PR workflow Feb 19, 2024
@mweberxyz mweberxyz marked this pull request as draft February 19, 2024 00:46
@mweberxyz mweberxyz marked this pull request as ready for review February 19, 2024 01:33
@mweberxyz mweberxyz marked this pull request as draft February 20, 2024 18:32
@mweberxyz
Copy link
Contributor Author

Changing to draft state - I would like to make a few changes to make the output more useful to what is requested in a typical PR conversation.

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 20, 2024

@mweberxyz
There is a bug in the benchmark flow.

can you take care of it please?

fastify/workflows#93

@mweberxyz
Copy link
Contributor Author

Leaving this draft for a little bit longer to see if there's any feedback on fastify/workflows#121, otherwise will return and go forward as is.

@mweberxyz
Copy link
Contributor Author

Turns out automating statistically significant, actionable benchmarks are easier said than done. Still spending time poking, but closing for now.

@mweberxyz mweberxyz closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants