Pass cache option to eta engine #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers,
While using this plugin with the https://github.com/eta-dev/eta template engine, I noticed that
NODE_ENV=productionnever cached the templates.After some digging I found the culprit:
point-of-viewnever sends the{ cache: true }option to theetaengineThis pull request solves this.
It can also be enabled by passing
production: trueto the engine.Benchmark
Rendering a simple template with
NODE_ENV=productionPerformance improvements:
Checklist
npm run testand the Code of conduct