correctly scope liquidjs errors #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #243. When the liquidjs engine throws an error the scope of the catch block has
reply.sendas undefined. this swallows the liquidjs error. This PR fixes the scoping issue and allows liquid js errors to be sent by fastify correctly.I'm not sure why https://github.com/fastify/point-of-view/blob/master/test/test-liquid.js#L439 doesn't catch this error. the error my code actually was getting from liquidjs was
err.message = 'ENOENT: Failed to lookup "${file}" in "${roots}"';I added a test to check this error but I couldn't make it fail before I made the change so not sure if it really helps.Checklist
npm run testandnpm run benchmarkand the Code of conduct