Match start with path (*)

[billouboq]

Help using fastify middleware when you want to match multiple routes with same starting url.

Needed it to switch from express :

router.all('/api/*', yourMiddleware);

to

fastify.use('/api/*', yourMiddleware);

[mcollina]

regexps are fairly expensive, I think we should avoid this regexp check for every request, but rather do it once. Maybe we need to change how we store functions and urls.

Regarding the indexOf and slice, we might have to write our own little functions that does a charcode-by-charcode comparison, as the slice call might be too expensive?

[billouboq]

this is a fairly expensive call, I think we should avoid this regexp check for every request, but rather do it once.

Don't know how you want to implement that, do you want to store it on instance with something that say "this middleware use * in route" ?

Regarding the indexOf and slice, we might have to write our own little functions that does a charcode-by-charcode comparison, as the slice call might be too expensive?

will dig into this later then, thanks for the review.

[mcollina]

I think we can store both urls and functions in a literal, with a property that tells if that has a wildcard or not.

[delvedor]

Completely agree with @mcollina, regex are too expensive. You can check how we are handling wildcards in our router, but this case is a bit different.

[billouboq]

@mcollina @delvedor changed implementation what's your thoughts?

[mcollina]

I think we can assign urls[i] to a variable, as we are accessing it everywhere.

urls[i].fn() will set this to urls[i], maybe this was happening before as well, but I think we should change it.

[billouboq]

About naming, feel to change whatever seems unclear to you. I always have hard times giving names.

urls[i].fn() will set this to urls[i], maybe this was happening before as well, but I think we should change it.

Not sure which context we want to assign to that function.

[mcollina]

@billouboq just fn = urls[i].fn, fn()

[delvedor]

I think you should store urls[i] in a variable and not only fn, since fn is called just one time, while urls[i] is called several times :)

[mcollina]

Good work! We are almost there.

[billouboq]

add variables and changes names to be more understandable.

[mcollina]

This is perfect, thanks!

[mcollina]

I've checked the benchamarks of fastify as well, and this does not introduce any overhead in the base cases.

[mcollina]

can you please send us a PR to the README as well? I think we should cover this there too.