-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve codebase and performance #41
Conversation
I was actually investigating if i could improve the original package of dougwilson. Then i saw you already created a fork. I hope you like it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disgusting, lgtm
Thank you xD. I added some unit tests for some edge cases, just to be on the safe side. Please just run the workflows again ;) I even had a faster implementation, but that would have been a security risk, as it would use recursion. And Forwarded-For is a security header, so I didnt wanted that somebody could raise a MaxStackCall Error and poitentially crashing the service. |
before:
after: