-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate test framework in build module #5683
Conversation
package.json
Outdated
{ | ||
"name": "Reidner Adnan", | ||
"url": "https://github.com/reidn3r", | ||
"email": "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this. That section of the package.json is left for the collaborators (also listed in the README).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! I misunderstood. I apologize.
@gurgunday could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please uninstall tap
Oh I see, I think we’d prefer a complete removal of tap in one PR rather than these incremental changes
I think that would be way too much. We should go for incremental updates like this PR is proposing. But we cannot do it with the current way tests are run: Lines 21 to 30 in 7ddced6
I don't think there's a guarantee that using |
Why did you close this? #5720 should be merged soon. |
These change are related to the issue #5555