add support for multi server #237
Conversation
dsalkamoses
force-pushed
the
multiserver
branch
from
a9490a7 to
167b294
Compare
|
This is missing docs and tests. I do not know which other features are missing between swagger and openapi, so I would be cautious. |
| @@ -59,7 +60,7 @@ module.exports = function (fastify, opts, next) { | |||
| // Base swagger info | |||
| // this info is displayed in the swagger file | |||
| // in the same order as here | |||
| swaggerObject.swagger = '2.0' | |||
| servers ? swaggerObject.openapi = '3.0.0' : swaggerObject.swagger = '2.0' | |||
There was a problem hiding this comment.
OAS 3.0 is not supported by this plugin and so the servers syntax.
So this change would not be enough to support it
There was a problem hiding this comment.
true. It worked for my use-case but as mcollina pointed out, this has to be thoroughly accounted for all the features that may be in use in the swagger 2.0 [currently looking into it]
There was a problem hiding this comment.
I was analysing how to solve the $ref, and I found this module @apidevtools/swagger-parser.
I think it could be useful to check the difference between the OAS2 and OAS3 formats.
Then, I thought what could be the macro-steps for this:
- collect all the schemas
- build one single schema (I working on it to support $ref and shared schemas)
- translate a JSON schema (draft 07 - since draft2019 is not broadly supported yet) to Swagger/OAS2.0 or OAS3 based on user options
- validate the generated OAS object
- render it
Addresses #236
Checklist
npm run testandnpm run benchmark