-
-
Notifications
You must be signed in to change notification settings - Fork 109
refactor: remove usage of deprecated request.routeConfig #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Uzlopak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a major release planned?
|
This plugin is now compatible with Fastify 5, where |
|
And does it throw an error if it does an access on that attribute? Or why do you state that this PR ensures compatility with fastify v5? |
|
That fallback is no longer reached. If remove |
|
So the answer to my question regarding "compatibiity" to fastify v5 is no and currently the plugins works without issues in v5. @fastify/plugins |
I made the assessment but I am not really convinced. Its up to you
|
I think we'd just need to do a major if dropping support for Fastify v4, and then updating the compatibility table accordingly. |
|
It looks like this plugin now requires Fastify v5 Lines 542 to 545 in c4185a5
|
Ah, good spot, thanks @inyourtime! Was looking at the compatibility table which was wrong. In that case, happy with this PR! |
gurgunday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct