feat: remove wildcard string support #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
approved these changes
Feb 17, 2021
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm
This option only caused confusion.
zekth
requested changes
Feb 17, 2021
Member
There was a problem hiding this comment.
missing the type changes
https://github.com/fastify/fastify-static/blob/master/index.d.ts#L58
zekth
approved these changes
Feb 17, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the support of passing string in
wildcardoption and it will throw an error whenwildcardis not aboolean.It also change the docs to add a new line about
newly added fileforwildcardequal tofalse.Actually, Issue 161 is not a bug and it do not need to be resolve. But this PR is raised from #161 (comment). So, I add it below.
Resolve: #161
Note: This is a breaking change.
Checklist
npm run testandnpm run benchmarkand the Code of conduct