docs: improve getting started example #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
May 27, 2022
README.md
Outdated
| // `fastify.scheduler` becomes available after initialization. | ||
| // Therefore, you need to call `ready` method. | ||
| fastify.ready().then(() => { | ||
| const task = new AsyncTask( |
There was a problem hiding this comment.
I would extract task and job definition outside of ready block, as they do not rely on app being up already
There was a problem hiding this comment.
@kibertoad
Thanks for your comment. I will fix it.
There was a problem hiding this comment.
@kibertoad
I fixed it. Could you review it again? 🙇
053691f
kibertoad
approved these changes
May 27, 2022
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
I tested the example code in StackBlitz.
https://stackblitz.com/edit/node-str32w?file=index.js
Checklist
npm run testandnpm run benchmarkand the Code of conduct