Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Module #78

Merged
merged 1 commit into from
May 27, 2022
Merged

Rename Module #78

merged 1 commit into from
May 27, 2022

Conversation

RafaelGSS
Copy link
Member

This pull request renames the module according to the discussion in
fastify/fastify#3733.

Note that the deprecation module has already been published and that the
code for it does not exist in this repository.

Coordinating the drastic changes to the code for the module deprecation and
then restoring the code for the module renaming would have been extremely
difficult and prohibitively tedious.

Important: no further releases should be added to the old major version.

@RafaelGSS
Copy link
Member Author

RafaelGSS commented May 26, 2022

I got a 128 status code when running it through deprecate-module tool (which seems a permission error). However, I was able to run it to fastify-awilix without issue.

So, I've created this PR manually.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs
Copy link
Member

Fdawgs commented May 27, 2022

Could you update the readme with the new name, and the plugin name as well please @RafaelGSS?

https://github.com/fastify/fastify-schedule/blob/main/lib/schedulePlugin.js#L18

@climba03003
Copy link
Member

Could you update the readme with the new name, and the plugin name as well please @RafaelGSS?

https://github.com/fastify/fastify-schedule/blob/main/lib/schedulePlugin.js#L18

The plugin name should remain the same for fastify@3.

@Fdawgs
Copy link
Member

Fdawgs commented May 27, 2022

Could you update the readme with the new name, and the plugin name as well please @RafaelGSS?
https://github.com/fastify/fastify-schedule/blob/main/lib/schedulePlugin.js#L18

The plugin name should remain the same for fastify@3.

Good point

@kibertoad
Copy link
Member

@RafaelGSS You can pull latest main to fix linting

This commit renames the module in accordance with the discussion in fastify/fastify#3733
@RafaelGSS
Copy link
Member Author

Can someone merge it? I don't have permission in this repo.

@Fdawgs Fdawgs merged commit 4c8d2dd into fastify:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants