Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in ajv instance #94

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Conversation

dancastillo
Copy link
Member

Checklist

index.js Outdated Show resolved Hide resolved
@dancastillo dancastillo requested a review from Eomm June 27, 2023 14:31
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion before merging 🚀

test/ajv.test.js Outdated Show resolved Hide resolved
test/ajv.test.js Outdated Show resolved Hide resolved
@dancastillo dancastillo requested a review from Eomm June 29, 2023 22:48
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Jul 1, 2023

Can you resolve the conflicts?

@dancastillo
Copy link
Member Author

@mcollina should be all set now

@Eomm Eomm merged commit 4478f52 into fastify:master Jul 2, 2023
15 checks passed
@felixfbecker
Copy link
Contributor

This is awesome, but unfortunately didn't update the TypeScript types

@felixfbecker
Copy link
Contributor

#96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants