Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dragonfly decorator #185

Closed
wants to merge 8 commits into from
Closed

feat: dragonfly decorator #185

wants to merge 8 commits into from

Conversation

ilteoood
Copy link

Resolves #184

Checklist

README.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the purpose of this, could you clarify? This seem to only change the name of the decorator.

@ilteoood
Copy link
Author

Hi @mcollina,
You are right: the purpose of this is just to define a different decorator name if the user wants to use this plugin with Dragonfly instead of Redis.
My idea behind this is just to improve the DX and avoid the user to type fastify.redis when he's not using Redis, but Dragonfly.

@kibertoad
Copy link
Member

kibertoad commented Aug 27, 2023

@ilteoood This seems to complicate the codebase for questionable benefits. I'm -1 on it.

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, developers will not get psychologycal damage by typing redis instead of dragonfly.

Also we have the namespace option.

So I am -1

@ilteoood
Copy link
Author

Ok then, at least I tried.
Thank you everyone for your time, feel free to close both the PR and the issue then

@mcollina mcollina closed this Aug 27, 2023
@ilteoood ilteoood deleted the feat/dragonfly-decorator branch August 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: decorate for dragonfly support
4 participants