Skip to content

replace hexoid with equivalent functionality #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

replace hexoid with equivalent functionality #441

merged 1 commit into from
May 17, 2023

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented May 17, 2023

fixes #366

Checklist

@Uzlopak Uzlopak requested review from mcollina May 17, 2023 10:15
@kibertoad
Copy link
Member

kibertoad commented May 17, 2023

So is this faster, slower or same?

mcollina
mcollina approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor Author

Uzlopak commented May 17, 2023

@kibertoad

Locally hexoid is 162 Mio Ops/s. This implementation is 200 Mio. Ops/s

@Uzlopak Uzlopak merged commit c849d93 into master May 17, 2023
@Uzlopak Uzlopak deleted the generate-id branch May 17, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kibertoad kibertoad kibertoad approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hexoid is not a function error upon plugin registration on server start

4 participants

@Uzlopak @kibertoad @mcollina