Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to fastify v3 #7

Merged
merged 1 commit into from May 14, 2020
Merged

Upgrade to fastify v3 #7

merged 1 commit into from May 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2020

Ref fastify/fastify#2217

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomheymann thomheymann mentioned this pull request May 11, 2020
Closed
51 tasks
@ghost
Copy link
Author

ghost commented May 14, 2020

Could this be merged now?

@mcollina mcollina merged commit e0eb4bd into fastify:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcollina