Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: support for embedded cors for route params (#278)" #285

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

climba03003
Copy link
Member

Revert #278
Closes #281
Closes #282

Checklist

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0f93883 into master Dec 18, 2023
21 checks passed
@mcollina mcollina deleted the fix branch December 18, 2023 11:59
renovate bot referenced this pull request in tomacheese/telcheck Dec 18, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cors](https://github.com/fastify/fastify-cors) | [`8.4.2`
->
`8.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.4.2/8.5.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcors/8.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcors/8.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcors/8.4.2/8.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcors/8.4.2/8.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cors (@&#8203;fastify/cors)</summary>

###
[`v8.5.0`](https://github.com/fastify/fastify-cors/releases/tag/v8.5.0)

[Compare
Source](https://github.com/fastify/fastify-cors/compare/v8.4.2...v8.5.0)

#### What's Changed

- chore(deps): bump mnemonist from 0.39.5 to 0.39.6 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/283](https://github.com/fastify/fastify-cors/pull/283)
- Revert "fix: support for embedded cors for route params
([#&#8203;278](https://github.com/fastify/fastify-cors/issues/278))"
by [@&#8203;climba03003](https://github.com/climba03003) in
[https://github.com/fastify/fastify-cors/pull/285](https://github.com/fastify/fastify-cors/pull/285)

**Full Changelog**:
fastify/fastify-cors@v8.4.2...v8.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preflight 404 on prefixed index routes in nested/scopted cors setups
4 participants