Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of OriginCallback #272

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix type of OriginCallback #272

merged 1 commit into from
Oct 2, 2023

Conversation

ken-browning
Copy link
Contributor

@ken-browning ken-browning commented Sep 29, 2023 •
edited
Loading

The documentation for the OriginCallback function states:

Function - set origin to a function implementing some custom logic. The function takes the request origin as the first parameter and a callback as a second (which expects the signature err [Error | null], origin), where origin is a non-function value of the origin option. Async-await and promises are supported as well.

This corrects the type. It is possible that the second parameter should be typed as ValueOrArray<OriginType> | Promise<ValueOrArray<OriginType>>. That last sentence is ambiguous and I haven't consulted the implementation.

@Fdawgs Fdawgs requested review from a team September 30, 2023 07:49
@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 30, 2023

Can you please add a typings test? We use tsd.

In the meanwhile i check if this is correct.

Eomm
Eomm approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The origin is propagated 👍🏼

Uzlopak
Uzlopak approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 042b14b into fastify:master Oct 2, 2023
15 checks passed
renovate bot referenced this pull request in tomacheese/telcheck Oct 29, 2023
@renovate
chore(deps): update dependency @fastify/cors to v8.4.1 (#354)
d06b7fb 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cors](https://github.com/fastify/fastify-cors) | [`8.4.0`
->
`8.4.1`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.4.0/8.4.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcors/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcors/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcors/8.4.0/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcors/8.4.0/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cors (@&#8203;fastify/cors)</summary>

###
[`v8.4.1`](https://github.com/fastify/fastify-cors/releases/tag/v8.4.1)

[Compare
Source](https://github.com/fastify/fastify-cors/compare/v8.4.0...v8.4.1)

#### What's Changed

- Fix type of OriginCallback by
[@&#8203;ken-browning](https://github.com/ken-browning) in
[https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272)
- test: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/273](https://github.com/fastify/fastify-cors/pull/273)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/274](https://github.com/fastify/fastify-cors/pull/274)
- test(index): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/275](https://github.com/fastify/fastify-cors/pull/275)

#### New Contributors

- [@&#8203;ken-browning](https://github.com/ken-browning) made their
first contribution in
[https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272)

**Full Changelog**:
fastify/fastify-cors@v8.4.0...v8.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel referenced this pull request in specfy/specfy Nov 22, 2023
@renovate
fix(deps): update dependency @fastify/cors to v8.4.1 (#364)
d833395 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/cors](https://github.com/fastify/fastify-cors) | [`8.3.0`
->
`8.4.1`](https://renovatebot.com/diffs/npm/@fastify%2fcors/8.3.0/8.4.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fcors/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fcors/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fcors/8.3.0/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fcors/8.3.0/8.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-cors (@&#8203;fastify/cors)</summary>

###
[`v8.4.1`](https://github.com/fastify/fastify-cors/releases/tag/v8.4.1)

[Compare
Source](https://github.com/fastify/fastify-cors/compare/v8.4.0...v8.4.1)

#### What's Changed

- Fix type of OriginCallback by
[@&#8203;ken-browning](https://github.com/ken-browning) in
[https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272)
- test: add `u` unicode flag to regex by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/273](https://github.com/fastify/fastify-cors/pull/273)
- chore(package): explicitly declare js module type by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/274](https://github.com/fastify/fastify-cors/pull/274)
- test(index): replace `typeof` undefined check by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/275](https://github.com/fastify/fastify-cors/pull/275)

#### New Contributors

- [@&#8203;ken-browning](https://github.com/ken-browning) made their
first contribution in
[https://github.com/fastify/fastify-cors/pull/272](https://github.com/fastify/fastify-cors/pull/272)

**Full Changelog**:
fastify/fastify-cors@v8.4.0...v8.4.1

###
[`v8.4.0`](https://github.com/fastify/fastify-cors/releases/tag/v8.4.0)

[Compare
Source](https://github.com/fastify/fastify-cors/compare/v8.3.0...v8.4.0)

#### What's Changed

- fix documentation, onRequest is default lifecycle stage by
[@&#8203;Uzlopak](https://github.com/Uzlopak) in
[https://github.com/fastify/fastify-cors/pull/254](https://github.com/fastify/fastify-cors/pull/254)
- perf(index): use spread over `Object.assign()` by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/257](https://github.com/fastify/fastify-cors/pull/257)
- docs(readme): add plugin compatibility table by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/258](https://github.com/fastify/fastify-cors/pull/258)
- test: cors headers sent when payload is stream by
[@&#8203;Uzlopak](https://github.com/Uzlopak) in
[https://github.com/fastify/fastify-cors/pull/260](https://github.com/fastify/fastify-cors/pull/260)
- Reduce bundle size by
[@&#8203;timedtext](https://github.com/timedtext) in
[https://github.com/fastify/fastify-cors/pull/266](https://github.com/fastify/fastify-cors/pull/266)
- chore(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)
from 5.62.0 to 6.4.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/267](https://github.com/fastify/fastify-cors/pull/267)
- chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-cors/pull/268](https://github.com/fastify/fastify-cors/pull/268)
- test: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/269](https://github.com/fastify/fastify-cors/pull/269)
- refactor(vary): use word character inside regex character class by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-cors/pull/270](https://github.com/fastify/fastify-cors/pull/270)

#### New Contributors

- [@&#8203;timedtext](https://github.com/timedtext) made their first
contribution in
[https://github.com/fastify/fastify-cors/pull/266](https://github.com/fastify/fastify-cors/pull/266)

**Full Changelog**:
fastify/fastify-cors@v8.3.0...v8.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Open
1 task
@Bad3r Bad3r mentioned this pull request May 22, 2024
Open
@Bad3r Bad3r mentioned this pull request Jun 12, 2024
Open
@Summonshr Summonshr mentioned this pull request Jun 29, 2024
Open
@Bad3r Bad3r mentioned this pull request Sep 8, 2024
Open
@gjovs gjovs mentioned this pull request Sep 10, 2024
Open
@Bad3r Bad3r mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 13, 2024
Open
Open
This was referenced Sep 17, 2024
Open
Open
@gjovs gjovs mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
This was referenced Sep 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@Eomm Eomm Eomm approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ken-browning @Uzlopak @Eomm @marco-ippolito