Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (types): add typescript definitions and tests #91

Merged
merged 10 commits into from
Feb 28, 2022

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Feb 12, 2022

Hello.

This PR aims to :

Checklist

plugin.d.ts Outdated Show resolved Hide resolved
plugin.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

plugin.js Outdated Show resolved Hide resolved
@darkgl0w
Copy link
Member Author

this PR is now ready to be merged if no changes are requested during the review process ^^

@darkgl0w darkgl0w merged commit ffa6a2c into fastify:master Feb 28, 2022
@darkgl0w darkgl0w deleted the add-typescript-definitions branch February 28, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typescript definitions
4 participants