Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override cache-control if it has already been set #122

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Don't override cache-control if it has already been set #122

merged 4 commits into from
Mar 28, 2023

Conversation

prevostc
Copy link
Contributor

Resolves #14

Checklist

Eomm
Eomm reviewed Mar 24, 2023
View reviewed changes
test/headers.test.js Outdated Show resolved Hide resolved
test/headers.test.js Outdated Show resolved Hide resolved
jsumners
jsumners reviewed Mar 25, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
jsumners
jsumners reviewed Mar 25, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@prevostc @jsumners
Cleaner comparison
6159450 
Co-authored-by: James Sumners <[email protected]>
jsumners
jsumners approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcollina mcollina merged commit 667f8e3 into fastify:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@jsumners jsumners jsumners approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only set cache for 200, 301 and 302 response
5 participants
@prevostc @jsumners @Eomm @Fdawgs @mcollina