-
-
Notifications
You must be signed in to change notification settings - Fork 75
feat: support native type stripping for Node >= v23 #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jean-michelet
merged 9 commits into
fastify:master
from
jean-michelet:support-native-type-stripping
Jan 31, 2025
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4b319e5
feat: support native type stripping for Node >= v23
jean-michelet 0149866
fix: remove unnecessary callback wraping
jean-michelet 6aedb09
docs: inform about native type stripping support for Node >= 23
jean-michelet 3dd6a7c
revert: log condition
jean-michelet 1306b77
fix: forgot && to run jest test
jean-michelet d7d65a0
docs: update related doc
jean-michelet eaedfe0
revert: style changes
jean-michelet d148a86
refactor: simplify condition
jean-michelet 7af7bb2
fix: nit
jean-michelet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| 'use strict' | ||
|
|
||
| const { exec } = require('node:child_process') | ||
| const runtime = require('../lib/runtime') | ||
|
|
||
| function common () { | ||
| const args = ['node', 'test/typescript-common/index.ts'] | ||
| const child = exec(args.join(' '), { | ||
| shell: true, | ||
| }) | ||
| child.stdout.pipe(process.stdout) | ||
| child.stderr.pipe(process.stderr) | ||
| child.once('close', esm) | ||
| } | ||
|
|
||
| function esm () { | ||
| const args = ['node', 'test/typescript-esm/forceESM.ts'] | ||
|
|
||
| const child = exec(args.join(' '), { | ||
| shell: true, | ||
| }) | ||
|
|
||
| child.stdout.pipe(process.stdout) | ||
| child.stderr.pipe(process.stderr) | ||
| child.once('close', process.exit) | ||
| } | ||
|
|
||
| if (runtime.nodeVersion >= 23) { | ||
| common() | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.