Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(lib/utils): cache ipv4 regex #115

Merged
merged 1 commit into from
Jan 5, 2025
Merged

perf(lib/utils): cache ipv4 regex #115

merged 1 commit into from
Jan 5, 2025

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 4, 2025

Cache the IPV4 regex, similar to how the uuid regex is cached in lib/schemes.js. Regex is expensive to create and garbage collect, so this should help a tad!

Checklist

gurgunday
gurgunday approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs merged commit 3f27cca into main Jan 5, 2025
22 checks passed
@Fdawgs Fdawgs deleted the perf/cache-regex branch January 5, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @gurgunday