Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: migrate to node test runner #80

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

ilteoood
Copy link
Contributor

@ilteoood ilteoood commented Jan 7, 2025

Checklist

@ilteoood ilteoood changed the title Migrate to node test runner BREAKING CHANGE: migrate to node test runner Jan 8, 2025
@ilteoood
Copy link
Contributor Author

ilteoood commented Jan 8, 2025

Hi @Uzlopak , @mcollina, @Fdawgs
according to what we discussed in fastify/deepmerge#58, as this introduces a breaking change as well, should I close even this PR?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is ok. It use tap.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Frazer Smith <[email protected]>
Signed-off-by: Matteo Pietro Dazzi <[email protected]>
@ilteoood ilteoood requested a review from Fdawgs January 10, 2025 17:45
.gitignore Outdated Show resolved Hide resolved
@ilteoood ilteoood requested a review from Fdawgs January 10, 2025 18:07
.gitignore Outdated Show resolved Hide resolved
Signed-off-by: Matteo Pietro Dazzi <[email protected]>
@Fdawgs Fdawgs merged commit f3ebc58 into fastify:master Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants