Skip to content

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Sep 6, 2024

This is a semver-major, it also move the minimum supported runtime to v20.

Checklist

Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
@mcollina mcollina requested review from Uzlopak and adrai September 6, 2024 15:34
Signed-off-by: Matteo Collina <[email protected]>
@adrai
Copy link
Member

adrai commented Sep 6, 2024

based on what I see it's not a major in user land... right?, theoretically there is no need to create a new version right now...?

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member Author

mcollina commented Sep 6, 2024

I'm shipping new majors for everything right now as the launch day is the 17th of September.

@mcollina
Copy link
Member Author

mcollina commented Sep 6, 2024

fastify/fastify#5659

@adrai
Copy link
Member

adrai commented Sep 6, 2024

ok, we can do a major bump to be aligned, but technically, @fastify/aws-lambda v5 will be the same like v4.1.0 for the users...
Do you want me to merge and release it now?

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@mcollina
Copy link
Member Author

I will ship it as the next tag, to be retagged when we release Fastify v5.

@adrai I can get to it if you agree.

@adrai
Copy link
Member

adrai commented Sep 10, 2024

I will ship it as the next tag, to be retagged when we release Fastify v5.

@adrai I can get to it if you agree.

Agree 👍

@adrai adrai merged commit 53dbb87 into master Sep 17, 2024
@adrai
Copy link
Member

adrai commented Sep 17, 2024

v5 has just been released ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants