Skip to content

chore(package): explicitly declare js module type #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Add option to retain the API Gateway stage in the URL passed to fastify
merged 1 commit into from
Oct 27, 2023
Merged

chore(package): explicitly declare js module type #181

merged 1 commit into from
Oct 27, 2023

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 27, 2023

See fastify/fastify-rate-limit#332

Checklist

@Fdawgs Fdawgs requested a review from adrai October 27, 2023 14:59
adrai
adrai approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@adrai adrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs merged commit f617965 into master Oct 27, 2023
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch October 27, 2023 15:09
@adrai
Copy link
Member

adrai commented Oct 27, 2023

Should we release a new version? patch ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrai adrai adrai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fdawgs @adrai