- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 36
fix: type in enforceBase64 callable #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type in enforceBase64 callable #121
Conversation
| Why should it be a light my request response? | 
| You can see it by the type written here. So  | 
| If you use .inject() in your typings than you have Response. If you use it in production (not injecting) it should be FastifyReply | 
| Code uses  | 
| Ah, makes sense. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @adrai | 
| Oh, the change makes a lot of sense. From my side, LGTM 👍 | 
| included in v3.1.1 | 
The type in the
enforceBase64callable is not ofFastifyReplytype butResponsefromlight-my-requestpackage.I changed code to note that the parameter is a
response, not areply.Also changed
replytoresponsein the explanation of theenforceBase64parameter in the docs.Checklist
npm run testandnpm run benchmarkand the Code of conduct