Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract loadPlugin #220

Merged
merged 2 commits into from
Jun 25, 2023
Merged

extract loadPlugin #220

merged 2 commits into from
Jun 25, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jun 25, 2023

I modified it, by passing the instance as a parameter instead of binding.

If you are against this change, I can change it to use again bind and this.

Checklist

@Uzlopak Uzlopak requested a review from mcollina June 25, 2023 08:59
mcollina
mcollina approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 5a83d50 into master Jun 25, 2023
@Uzlopak Uzlopak deleted the extract-plugin-loading branch June 25, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina