Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: nodejs version update #179

Merged
merged 1 commit into from
Mar 10, 2022
Merged

ci: nodejs version update #179

merged 1 commit into from
Mar 10, 2022

Conversation

xtx1130
Copy link
Contributor

@xtx1130 xtx1130 commented Mar 10, 2022

Fastify main branch has update nodejs version to 14,16,17. I think it is necessary to keep versions the same with Fastify

Checklist

RafaelGSS
RafaelGSS approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit bff3454 into fastify:master Mar 10, 2022
@xtx1130 xtx1130 deleted the ci-node-version-update branch March 14, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtx1130 @mcollina @RafaelGSS