update for Fastify v5 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Feb 25, 2024
index.js
Outdated
| @@ -8,7 +8,7 @@ function Negotiator (options) { | |||
| const { | |||
| supportedValues = [], | |||
| cache | |||
| } = (options && typeof options === 'object' && options) || {} | |||
| } = (typeof options === 'object' && options) || {} | |||
There was a problem hiding this comment.
What does it do? It looks funny 😄
But I see it's irrelevant
There was a problem hiding this comment.
first you have the null check, then you check if is an object, if true return that object. seems odd, but it should be faster than having the string comparison first. ;)
There was a problem hiding this comment.
I think typeof no longer does string comparison, it has specific bytecode so it's as fast as it gets
Will check it again though
There was a problem hiding this comment.
FYI:
function isString(exp) {
return typeof exp === "string";
}
console.log(isString("hello")); 27 S> 0xeb02adde136 @ 0 : 0b 03 Ldar a0
0xeb02adde138 @ 2 : 20 01 TestTypeOf #1
58 S> 0xeb02adde13a @ 4 : a9 Return
|
Removed the |
jsumners
pushed a commit
that referenced
this pull request
Jul 3, 2024
* update for v5 * add pre-commit * package-manager v4 * revert change * remove engines field
jsumners
added a commit
that referenced
this pull request
Jul 5, 2024
* update for Fastify v5 (#30) * update for v5 * add pre-commit * package-manager v4 * revert change * remove engines field * workflows: extend the test range (#32) * test for lts from 14 to 20 * test from 16 * update * update for Fastify v5 (#30) * update for v5 * add pre-commit * package-manager v4 * revert change * remove engines field * workflows: extend the test range (#32) * test for lts from 14 to 20 * test from 16 * update * update ci --------- Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26