Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync pref improvements #61

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Sync pref improvements #61

merged 4 commits into from
Nov 8, 2024

Conversation

sizets
Copy link
Contributor

@sizets sizets commented Nov 7, 2024

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AnalogJ
❌ sizets
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 194 lines in your changes missing coverage. Please review.

Project coverage is 20.44%. Comparing base (2f6ff66) to head (84b4609).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
tools/test-smart-client/main.go 0.00% 130 Missing ⚠️
...ools/test-smart-client/utils/storage_repository.go 0.00% 36 Missing ⚠️
tools/test-smart-client/utils/jsonl.go 0.00% 27 Missing ⚠️
clients/internal/base/fhir401_client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   22.58%   20.44%   -2.14%     
==========================================
  Files          13       33      +20     
  Lines        2909     3800     +891     
==========================================
+ Hits          657      777     +120     
- Misses       2143     2919     +776     
+ Partials      109      104       -5     
Flag Coverage Δ
unittests 20.44% <0.00%> (-2.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnalogJ AnalogJ merged commit af176a8 into main Nov 8, 2024
5 of 9 checks passed
@AnalogJ AnalogJ deleted the sync_pref_improvements branch November 30, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants