Skip to content

✅ Fix mocks in tests #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 17, 2025
Merged

✅ Fix mocks in tests #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de2fbc0
Update
alejsdev Sep 11, 2025
6208163
Update
alejsdev Sep 11, 2025
d360726
Trigger CI
alejsdev Sep 11, 2025
5db9175
Update
alejsdev Sep 11, 2025
f0dc306
Format
alejsdev Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 37 additions & 15 deletions tests/test_cli_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_shows_waitlist_form_when_not_logged_in(
).mock(return_value=Response(200))

with changing_dir(tmp_path), patch(
"rich_toolkit.menu.click.getchar"
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

Expand Down Expand Up @@ -138,7 +138,7 @@ def test_shows_waitlist_form_when_not_logged_in_longer_flow(
).mock(return_value=Response(200))

with changing_dir(tmp_path), patch(
"rich_toolkit.menu.click.getchar"
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

Expand All @@ -153,7 +153,7 @@ def test_asks_to_setup_the_app(logged_in_cli: None, tmp_path: Path) -> None:
steps = [Keys.RIGHT_ARROW, Keys.ENTER]

with changing_dir(tmp_path), patch(
"rich_toolkit.menu.click.getchar"
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

Expand All @@ -171,7 +171,9 @@ def test_shows_error_when_trying_to_get_teams(

respx_mock.get("/teams/").mock(return_value=Response(500))

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand All @@ -189,7 +191,9 @@ def test_handles_invalid_auth(

respx_mock.get("/teams/").mock(return_value=Response(401))

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand All @@ -215,7 +219,9 @@ def test_shows_teams(
)
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand All @@ -239,7 +245,9 @@ def test_asks_for_app_name_after_team(
)
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand Down Expand Up @@ -268,7 +276,9 @@ def test_creates_app_on_backend(
return_value=Response(201, json=_get_random_app(team_id=team["id"]))
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand All @@ -294,7 +304,9 @@ def test_uses_existing_app(
return_value=Response(200, json={"data": [app_data]})
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand Down Expand Up @@ -367,7 +379,9 @@ def test_exits_successfully_when_deployment_is_done(
)
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand Down Expand Up @@ -615,7 +629,9 @@ def _deploy_without_waiting(respx_mock: respx.MockRouter, tmp_path: Path) -> Res
return_value=Response(200)
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

return runner.invoke(app, ["deploy", "--no-wait"])
Expand Down Expand Up @@ -687,7 +703,9 @@ def test_creates_environment_variables_during_app_setup(
f"/apps/{app_data['id']}/environment-variables/", json={"API_KEY": "secret123"}
).mock(return_value=Response(200))

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand Down Expand Up @@ -731,7 +749,9 @@ def test_rejects_invalid_environment_variable_names(
f"/apps/{app_data['id']}/environment-variables/", json={"VALID_KEY": "value123"}
).mock(return_value=Response(200))

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand All @@ -754,7 +774,7 @@ def test_shows_error_for_invalid_waitlist_form_data(
]

with changing_dir(tmp_path), patch(
"rich_toolkit.menu.click.getchar"
"rich_toolkit.container.getchar"
) as mock_getchar, patch("rich_toolkit.form.Form.run") as mock_form_run:
mock_getchar.side_effect = steps
# Simulate form returning data with invalid email field to trigger ValidationError
Expand Down Expand Up @@ -789,7 +809,9 @@ def test_shows_no_apps_found_message_when_team_has_no_apps(
return_value=Response(200, json={"data": []})
)

with changing_dir(tmp_path), patch("click.getchar") as mock_getchar:
with changing_dir(tmp_path), patch(
"rich_toolkit.container.getchar"
) as mock_getchar:
mock_getchar.side_effect = steps

result = runner.invoke(app, ["deploy"])
Expand Down
4 changes: 3 additions & 1 deletion tests/test_env_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ def test_shows_selector_for_environment_variables(
return_value=Response(204)
)

with changing_dir(configured_app), patch("click.getchar", side_effect=steps):
with changing_dir(configured_app), patch(
"rich_toolkit.container.getchar", side_effect=steps
):
result = runner.invoke(app, ["env", "delete"])

assert result.exit_code == 0
Expand Down
4 changes: 3 additions & 1 deletion tests/test_env_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ def test_asks_for_name_and_value(
return_value=Response(200)
)

with changing_dir(configured_app), patch("click.getchar", side_effect=steps):
with changing_dir(configured_app), patch(
"rich_toolkit.container.getchar", side_effect=steps
):
result = runner.invoke(app, ["env", "set"])

assert result.exit_code == 0
Expand Down