⬆️ Migrate to uv #127
⬆️ Migrate to uv #127
Conversation
DoctorJohn
force-pushed
the
migrate-to-uv
branch
4 times, most recently
from
4d7a531 to
fca192c
Compare
DoctorJohn
force-pushed
the
migrate-to-uv
branch
from
fca192c to
d58c678
Compare
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Nice! Super cool! 🚀
I see several tricks I didn't know about and now I want to copy them to other projects. 🙌
I have a couple of small comments here and there. 🤓
| run: uv build | ||
| - name: Publish | ||
| uses: pypa/gh-action-pypi-publish@v1.13.0 | ||
| run: uv publish |
There was a problem hiding this comment.
For the publish setup I would prefer to keep the pypa action, at least for now. Also the python -m build.
There was a problem hiding this comment.
We're back to vanilla building and publishing now. But I'm curious, is there a particular reason for that preference? I'm using UV build + publish with GitHub as Trusted Publisher for all my open source repos without any issues. Just curious, no need to overthink it.
There was a problem hiding this comment.
On one hand to not do all the changes at once just in case something breaks, but deep down I was also assuming uv wouldn't work with the trusted publisher stuff, if you've been already using it, it should be fine. 🤔
I'll then leave it up to you. 🙌
There was a problem hiding this comment.
That's fair! Let's give it a try in this repository and see how it goes. This single PR could then serve as a template for potentially migrating all other projects as well 🙌
DoctorJohn
force-pushed
the
migrate-to-uv
branch
from
98fb1da to
8e49b4a
Compare
DoctorJohn
force-pushed
the
migrate-to-uv
branch
from
8e49b4a to
3cc90f0
Compare
DoctorJohn
force-pushed
the
migrate-to-uv
branch
from
3cc90f0 to
c68f6fd
Compare
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
This looks great! 🎉
Now I want it for all my repos. 🤩
No description provided.