Skip to content

✨ Add support for all Field parameters from Pydantic 1.9.0 and above, make Pydantic 1.9.0 the minimum required version #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2023
Merged

✨ Add support for all Field parameters from Pydantic 1.9.0 and above, make Pydantic 1.9.0 the minimum required version #440

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6728c25
✨ Add support for all `Field` parameters from Pydantic version `1.9.0`
daniil-berg Sep 7, 2022
57e05ab
🔧 Skip tests for `discriminator` param (needs Python `3.8+`)
daniil-berg Sep 7, 2022
45d5eb1
Merge branch 'main' into pydantic-1.9.0-field-params
tiangolo Dec 16, 2022
5ff6d2a
Merge branch 'main' into pydantic-1.9.0-field-params
tiangolo Oct 25, 2023
470e813
♻️ Import from typing_extensions to support Python 3.7
tiangolo Oct 26, 2023
8bc6450
🔥 Remove test for unique_items as it was removed from Pydantic v2
tiangolo Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions tests/test_pydantic/test_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from decimal import Decimal
from typing import List, Optional, Union
from typing import Optional, Union

import pytest
from pydantic import ValidationError
Expand All @@ -22,16 +22,6 @@ class Model(SQLModel):
Model(dec=Decimal("420"))


def test_unique_items():
class Model(SQLModel):
unique_strings: List[str] = Field(unique_items=True)

Model(unique_strings=["x", "y"])

with pytest.raises(ValidationError):
Model(unique_strings=["x", "y", "x"])


Copy link

@MRigal MRigal Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove and not skipif, as pydantic v2 support is not present now?

Please note that if that means Pydantic v2 support in few days, I'm fine with it ;-)

Copy link
Member

@tiangolo tiangolo Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the plan is to support SQLAlchemy 2.0 and Pydantic 2.0 as soon as possible. 🤓

def test_discriminator():
# Example adapted from
# [Pydantic docs](https://pydantic-docs.helpmanual.io/usage/types/#discriminated-unions-aka-tagged-unions):
Expand Down