Skip to content

Catch user update integrity error #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertop23 wants to merge 2 commits into from
Closed

Catch user update integrity error #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db24bc
Update users.py
robertop23 Apr 21, 2021
4bf5386
Update users.py
robertop23 Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions {{cookiecutter.project_slug}}/backend/app/app/api/api_v1/endpoints/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from fastapi.encoders import jsonable_encoder
from pydantic.networks import EmailStr
from sqlalchemy.orm import Session
from sqlalchemy import exc

from app import crud, models, schemas
from app.api import deps
Expand Down Expand Up @@ -71,7 +72,12 @@ def update_user_me(
user_in.full_name = full_name
if email is not None:
user_in.email = email
user = crud.user.update(db, db_obj=current_user, obj_in=user_in)
try:
user = crud.user.update(db, db_obj=current_user, obj_in=user_in)
except exc.IntegrityError:
raise HTTPException(
status_code=409, detail="User with this email already exists"
)
return user


Expand Down Expand Up @@ -149,5 +155,10 @@ def update_user(
status_code=404,
detail="The user with this username does not exist in the system",
)
user = crud.user.update(db, db_obj=user, obj_in=user_in)
try:
user = crud.user.update(db, db_obj=current_user, obj_in=user_in)
except exc.IntegrityError:
raise HTTPException(
status_code=409, detail="User with this email already exists"
)
return user