Remove Package.resolved and add a typealias #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
saeta
approved these changes
Jul 3, 2020
|
Note: the CI failures appear to be unrelated (and present in a variety of past merged PRs), so I'm going to go ahead and merge this in. Thanks @texasmichelle ! |
texasmichelle
changed the title
This was referenced Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This week, the S4TF team encountered several failures building toolchains:
ParameterlessLayercaused by a change in type inference behavior in apple/swift#32578.This PR includes two workarounds that unblock toolchain builds:
ParameterlessLayer, which was effective in swift-apis and swift-models (see tensorflow/swift-apis#1037).I'm happy to create an additional PR to remove the other Package.resolved files in this repo and add to .gitignore, if desired.