-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix optimwrapper to work with param_groups (closes #2829) #3241
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I just realized that by switching the arguments of I have added this change as a commit, but @jph00 please let me know if you are fine with this. If you think it's too much change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Minor suggestions
Co-authored-by: Jeremy Howard <[email protected]>
@tmabraham any chance you could look to see why one notebook is timing out in tests in CI? |
@jph00 fixed! surprised this wasn't an issue before but one of the cells was not marked slow... |
Thank you! :) |
Currently,
OptimWrapper
does not supportparam_groups
, preventing use of model freezing/unfreezing and discriminative learning rate.This PR incorporates @muellerzr's fix into
OptimWrapper
. In doing so, the usage ofOptimWrapper
is slightly changed. For example, it changes usage from:to
This PR will also solve issue #2829 as well.