Faro upstream/feature/pkce #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
…odes. Signed-off-by: justin-slowik <[email protected]>
* Added /device/token handler with associated business logic and storage tests. * Use crypto rand for user code Signed-off-by: justin-slowik <[email protected]>
* Added /device/token handler with associated business logic and storage tests. Perform user code exchange, flag the device code as complete. Moved device handler code into its own file for cleanliness. Cleanup * Removed PKCE code * Rate limiting for /device/token endpoint based on ietf standards * Configurable Device expiry Signed-off-by: justin-slowik <[email protected]>
Extracted test cases from OAuth2Code flow tests to reuse in device flow deviceHandler unit tests to test specific device endpoints Include client secret as an optional parameter for standards compliance Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]>
Signed-off-by: justin-slowik <[email protected]> Remove extraneous "=" from conformance.go Co-authored-by: Joel Speed <[email protected]> Additional test for TestHandleDeviceCode Signed-off-by: justin-slowik <[email protected]>
Implementing the OAuth2 Device Authorization Grant
discovery endpoint /dex/.well-known/openid-configuration now has the following entry: "code_challenge_methods_supported": [ "S256", "plain" ] Signed-off-by: Bernd Eckstein <[email protected]>
Signed-off-by: Bernd Eckstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.