Skip to content

General missing/invalid client_secret message on token endpoint #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HEllRZA merged 1 commit into from
Oct 16, 2020
Merged

General missing/invalid client_secret message on token endpoint #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions server/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,11 +759,12 @@ func (s *Server) handleToken(w http.ResponseWriter, r *http.Request) {
}
return
}
if clientSecret == "" && client.Secret != "" && r.PostFormValue("code_verifier") != "" {
s.logger.Infof("detected PKCE token request without client_secret on client %s. "+
"Set the client to be pubic without client_secret, if you want to allow this.", client.ID)
}
if client.Secret != clientSecret {
if clientSecret == "" {
s.logger.Infof("missing client_secret on token request for client: %s", client.ID)
} else {
s.logger.Infof("invalid client_secret on token request for client: %s", client.ID)
}
s.tokenErrHelper(w, errInvalidClient, "Invalid client credentials.", http.StatusUnauthorized)
return
}
Expand Down