Fix non-responsive zoom by unifying zoom→distance mapping in camera state #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate **** Context: On Android, cameraState.animateCamera(zoom = …) updates zoom correctly. On iOS, zoom buttons appeared to do nothing. **** Root cause: Inconsistent conversion of zoom level to MapKit camera distance. Initialization used a lookup-based zoomToDistance(zoom), while animateCamera used a different “base distance” formula; the mismatch produced negligible distance changes, so the zoom effect wasn’t visible. **** Changes: KrossCameraPositionState.ios.kt: use zoomToDistance(zoom) in animateCamera same mapping as initialization. Remove the “base distance” logic and unused helper that caused an unresolved reference linter error. Keep tilt/bearing behavior unchanged. **** Impact: Zoom buttons now work on iOS and match Android behavior. Code is simpler and consistent; linter error resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**** Context:
On Android, cameraState.animateCamera(zoom = …) updates zoom correctly.
On iOS, zoom buttons appeared to do nothing.
**** Root cause:
Inconsistent conversion of zoom level to MapKit camera distance.
Initialization used a lookup-based zoomToDistance(zoom), while animateCamera used a different “base distance” formula; the mismatch produced negligible distance changes, so the zoom effect wasn’t visible.
**** Changes:
KrossCameraPositionState.ios.kt: use zoomToDistance(zoom) in animateCamera same mapping as initialization.
Remove the “base distance” logic and unused helper that caused an unresolved reference linter error.
Keep tilt/bearing behavior unchanged.
**** Impact:
Zoom buttons now work on iOS and match Android behavior.
Code is simpler and consistent; linter error resolved.
Adds
centerproperty toKrossCameraPositionState