-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of devDependencies #95
Conversation
1 similar comment
@ritmas Thanks for your pull request! |
Well, it's nice to have support for as wide range of versions as possible. On another hand, it's unclear how would it affect performance. |
Probably performance wouldn't be much affected, but to keep dependencies updated we might need to drop support for old node versions that are not supported by dependencies anymore. |
@farhadi probably you're right - eventually we would need to drop support of older/outdated versions, but is v4 the right choice? The most recent one still under maintenance is v6. |
I think Version 1 is the best approach. As per my understanding, after Version 1 changes are done, we can still add support for older Node versions by adding safer-buffer polyfill as described in Version 2. safer-buffer is already being added as a dependency of iconv-lite anyways. Once old Node versions support is dropped, it will be as easy as to remove two lines of code and remove safer-buffer dependency. I'll have some free time soon so I'm willing to create PR for this. But, IMHO, just going Version 1 is even better. Edit: PR #98 was implemented for buffer related changes. |
closing in favor of #117 |
Update of
devDependencies
by preserving backward compatability of older Node / npm versions.Introduced custom wrapper
Utils.Buffer()
for handling breaking changes of obsoletenew Buffer()
constructor, otherwise error will keep occuring like:According to nodejs.org guide how to port it, I've chosen Version 3 because:
Version 1
drops backward compatability of older Node / npm versionsVersion 2
would still allow throwingDeprecationWarning
warning