Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GSM language shift tables #100

Merged
merged 8 commits into from
May 22, 2019
Merged

Support GSM language shift tables #100

merged 8 commits into from
May 22, 2019

Conversation

juliangut
Copy link
Collaborator

@juliangut juliangut commented Apr 9, 2019

This PR adds support to GSM language shift tables as presented in issue #91

Added support for receiving and sending GSM messages encoded with shift tables, currently Turkish, Spanish and Portuguese but can be easily extended for other languages

Information about shift tables can be found here: https://en.wikipedia.org/wiki/GSM_03.38

Mind that for this task to be achieved UDH must be parsed and understood in order to retrieve selected shift table. udh field is returned now as an array of Buffer without total udh length

having this UDH Buffer([0x08, 0x24, 0x01, 0x03, 0x00, 0x03, 0x08, 0x02, 0x01]), udh field will store:

[
    Buffer([0x24, 0x01, 0x03]), // Language Shift Table (portuguese)
    Buffer([0x00, 0x03, 0x08, 0x02, 0x01]) // 8bit Concatenated short message (part 1 of 2)
]

@coveralls
Copy link

coveralls commented Apr 9, 2019

Coverage Status

Coverage increased (+1.2%) to 75.692% when pulling 9cbcd9f on juliangut:master into 1da445d on farhadi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-43.2%) to 31.301% when pulling 819bd4a on juliangut:master into 1da445d on farhadi:master.

@juliangut juliangut mentioned this pull request Apr 16, 2019
@farhadi farhadi merged commit 08f925e into farhadi:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants