Skip to content

Enhance the pass of fault tolerance results - #242

Merged
fangyuchu merged 1 commit into
feature/ft-simplifyfrom
fyc-dev
Jul 7, 2026
Merged

Enhance the pass of fault tolerance results#242
fangyuchu merged 1 commit into
feature/ft-simplifyfrom
fyc-dev

Conversation

@fangyuchu

@fangyuchu fangyuchu commented Jul 7, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Owner

Purpose

Test Plan

tested with dp4 tp1 by raising exception on rank 1

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 7, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the fault tolerance configuration and payload validation, and migrates the fault tolerance communication to use structured msgspec objects (FaultToleranceResult) instead of raw dictionaries. The review feedback highlights two important issues: a typo in the warning message in arg_utils.py where a Chinese full stop is used, and a potential AttributeError in api_router.py if the request body is not a dictionary, which could lead to unhandled 500 errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread vllm/engine/arg_utils.py
Comment thread vllm/entrypoints/serve/fault_tolerance/api_router.py
@fangyuchu
Enhance the pass of fault tolerance results
18d904d 
Signed-off-by: fangyuchu <fangyuchu@qq.com>
@fangyuchu
fangyuchu merged this pull request into feature/ft-simplify Jul 7, 2026
1 check passed
fangyuchu added a commit that referenced this pull request Jul 14, 2026
@fangyuchu
Enhance the pass of fault tolerance results (#242)
54521c0 
Signed-off-by: fangyuchu <fangyuchu@qq.com>
fangyuchu added a commit that referenced this pull request Jul 20, 2026
@fangyuchu
Enhance the pass of fault tolerance results (#242)
829a5b7 
Signed-off-by: fangyuchu <fangyuchu@qq.com>
fangyuchu added a commit that referenced this pull request Jul 23, 2026
@fangyuchu
Enhance the pass of fault tolerance results (#242)
4825e32 
Signed-off-by: fangyuchu <fangyuchu@qq.com>
zWaNg3 added a commit to zWaNg3/vllm that referenced this pull request Jul 25, 2026
@zWaNg3 @claude
Squash: Fault Tolerance Framework - 16 commits from fyc_vllm/feature/…
564f7f5 
…ft-simplify

This squashes the following commits into one:
- Fault Tolerance Framework (fangyuchu#229)
- unify param name for nixl and deepep and destroy old cpu_group in retry (fangyuchu#230)
- Surface exception to status
- change status report mode from pull to push
- simplify fault tolerance config args
- use existing get_all2all_manager implementation
- support tp>1 (fangyuchu#241)
- Enhance the pass of fault tolerance results (fangyuchu#242)
- clean states for model runner v2
- add support for fault detection through mask for model runner v2
- [FT] validate single API server, fix clean_buffers ordering and worker state cleanup
- [FT] make apply endpoint async and gate recovery by engine status
- add e2e test for fault tolerance
- add e2e test for retry recovery
- refactor e2e tests with concurrent polling and add Buildkite CI config (fangyuchu#250)
- set cpu timeout to default value of nixl-ep in test (fangyuchu#251)

Co-Authored-By: Claude <noreply@anthropic.com>
fangyuchu added a commit that referenced this pull request Jul 25, 2026
@fangyuchu
Enhance the pass of fault tolerance results (#242)
89b31e0 
Signed-off-by: fangyuchu <fangyuchu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fangyuchu