Skip to content

[Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var - #106

Merged
fangyuchu merged 2 commits into
fangyuchu:feature/ft-frameworkfrom
205150940:feature/ft-framework
Aug 21, 2026
Merged

fangyuchu merged 2 commits into
fangyuchu:feature/ft-frameworkfrom
205150940:feature/ft-framework

Conversation

@205150940

Copy link
Copy Markdown

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@205150940
205150940 force-pushed the feature/ft-framework branch from 8d6c6ae to 7a676e0 Compare August 20, 2026 12:38
Comment thread vllm_ascend/ascend_config.py Outdated

_MEGA_MOE_SUPPORTED = importlib.util.find_spec("cann_ops_transformer") is not None

# Minimum enabled value (seconds) for ft_communication_abort_timeout.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用专门定义变量吧,直接在后面校验的时候比较大小就行吧

@205150940 205150940 Aug 21, 2026 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

torch_npu.npu.set_op_timeout_ms(get_ascend_config().ft_communication_ops_abort_timeout_ms)
abort_timeout = get_ascend_config().ft_communication_abort_timeout
if abort_timeout > 0:
# User-provided HCCL timeouts win; otherwise derive them

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用加这么多注释

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Signed-off-by: TianZhuo <2770730562@qq.com>
@205150940
205150940 force-pushed the feature/ft-framework branch from ffec4a8 to 0316f6f Compare August 21, 2026 01:28
@fangyuchu
fangyuchu merged commit f4cfea2 into fangyuchu:feature/ft-framework Aug 21, 2026
2 of 3 checks passed
205150940 added a commit to 205150940/vllm-ascend that referenced this pull request Aug 24, 2026
…chu#106)

* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fangyuchu pushed a commit that referenced this pull request Aug 24, 2026
* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fangyuchu pushed a commit that referenced this pull request Aug 25, 2026
* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
205150940 added a commit to 205150940/vllm-ascend that referenced this pull request Aug 27, 2026
…chu#106)

* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fangyuchu pushed a commit that referenced this pull request Aug 29, 2026
* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fangyuchu pushed a commit that referenced this pull request Aug 29, 2026
* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
205150940 added a commit to 205150940/vllm-ascend that referenced this pull request Sep 4, 2026
…chu#106)

* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
fangyuchu pushed a commit that referenced this pull request Sep 9, 2026
* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
205150940 added a commit to 205150940/vllm-ascend that referenced this pull request Sep 11, 2026
…chu#106)

* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zWaNg3 pushed a commit that referenced this pull request Sep 20, 2026
* [Refactor] Drop FT_COMMUNICATION_OPS_ABORT_TIMEOUT_MS env var

Signed-off-by: TianZhuo <2770730562@qq.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: TianZhuo <2770730562@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants