Add --cacert and --proxy-cacert #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FREE()` checks for a `NULL` pointer, but generally httpdirfs does not `NULL` out pointers it attempts to `FREE()` (or `free()`). As such, the error message is misleading; make it less so in a trivial way. Possibly a better, more invasive, change would be for `FREE()` to take a `void** pp`, check that `*p != NULL`, `free(*p)`, and then `*p = NULL;`. Were that done, then there would be some plausibility to the current diagnostic message.
It's entirely possible that `ts.data` is `NULL` on an error path, so handing it to `FREE()`, which bails on a `NULL` argument, is not ideal. Just pass it to `free()` instead, which is required to no-op if given `NULL`.
|
Looks good to me, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #108 While here, fix two other nits.