Two small patches #104
Two small patches #104
Conversation
On platforms with an unsigned char, such as Arm, this results in always taking error paths around initialization. Fixes #103
The use of EACCES leads to slightly confusing error messages in downstream consumers, so prefer EROFS to better articulate what's actually happening. While here, use O_RDWR to mask the open flags while testing for non-RO access. This is at least encouraged by POSIX with their suggestion that "O_RDONLY | O_WRONLY == O_RDWR".
|
Thanks. This is brilliant! |
|
Nice! @fangfufu Would it be possible to release a new version (1.2.4) with that fix included? Need that to run httpdirfs on aarch64 / Asahi Linux on Apple Silicon M1. Thanks! |
|
You can just compile the latest master branch, no? These patches are merged in. |
|
Yeah, I did, kind of, that just now. I am new to Arch Linux and still figuring things out... |
|
(I cherry-picked because I was not sure if the master branch is stable, so I stayed on the 1.2.3 release) |
|
However, a new patch release would still be nice, so the AUR package (https://aur.archlinux.org/packages/httpdirfs) could use it, which would be a much better user experience for arm/aarch64 users (instead of patching by him/herself). Thanks! |
One fixes #103 and the other just slightly improves error messages in downstream consumers who mistakenly ask to support writes when
opening files.