refactor: Improve linebreak logic for html messages #2022
Conversation
krille-chan
force-pushed
the
krille/fix-linebreaks-in-html-messages-correctly
branch
from
3abfc9b to
552881d
Compare
lib/src/utils/markdown.dart
Outdated
| text = text | ||
| .trim() | ||
| .split('\n') | ||
| .map((line) => line.isEmpty ? '\u200C' : line) |
There was a problem hiding this comment.
You can not used this symbol as workaround because it used in Persian alphabet
https://en.wikipedia.org/wiki/Zero-width_non-joiner
There was a problem hiding this comment.
What about the zero width space character U+200B then?
There was a problem hiding this comment.
I changed it to marking it with a newly defined /newline marker. This gets ignored in markdown itself. The only side effect would be, that the user could type /newline everywhere which would be converted to a normal linebreak
krille-chan
force-pushed
the
krille/fix-linebreaks-in-html-messages-correctly
branch
from
552881d to
d255b8b
Compare
krille-chan
force-pushed
the
krille/fix-linebreaks-in-html-messages-correctly
branch
from
d255b8b to
c75c1cd
Compare
krille-chan
force-pushed
the
krille/fix-linebreaks-in-html-messages-correctly
branch
from
c75c1cd to
2446740
Compare
| // in all empty lines to keep the lines as the user added them and workaround | ||
| // the markdown rules for multiple empty lines. | ||
| text = text | ||
| .replaceAll('/newline', '\n') |
There was a problem hiding this comment.
This feels very hacky, what if people send /newline/newline/newline or so?
There was a problem hiding this comment.
Then they will have three new lines. I thought as we support commands with /anything anyway this is the best compromise. We already wasted countless hours to find a non hacky solution and havent found one
Closes #1691
Tested in FluffyChat: