Skip to content

refactor: Push Notification helper class make all fields optional and migrate dynamics to Object? #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

krille-chan
Copy link
Contributor

No description provided.

@krille-chan krille-chan requested a review from a team as a code owner January 7, 2025 09:52
Copy link
Contributor

@coder-with-a-bushido coder-with-a-bushido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change right? can we pls have the commit say it?

@krille-chan krille-chan force-pushed the krille/refactor-push-notification-object branch from d24a231 to 2e8bae8 Compare January 8, 2025 08:43
@coder-with-a-bushido coder-with-a-bushido merged commit 32e051c into main Jan 8, 2025
15 checks passed
@coder-with-a-bushido coder-with-a-bushido deleted the krille/refactor-push-notification-object branch January 8, 2025 09:09
@ghost ghost mentioned this pull request Feb 3, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants