-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change power level without changing memory #1929
Conversation
c3e282a
to
7014278
Compare
1fd31c2
to
3de1c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking I guess there could be an edge case if the users map is set to a list, where we won't set the permissions ever now. I think those rooms probably fail to federate and so this is fine and we don't need to care about it :D
e551c87
to
6c8424a
Compare
The problem here is that we have not created a deep copy of the power level map. By using .copy() we create a deep copy now.
6c8424a
to
4a754de
Compare
The problem here is that we
have not created a deep copy
of the power level map. By using .copy() we create a
deep copy now.
Closes https://github.com/famedly/product-management/issues/2412