Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: state updates being also applied when fetching history #1846

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: state updates being also applied when fetching history #1846

merged 1 commit into from
Jun 10, 2024

Conversation

nico-famedly
Copy link
Member

This could sometimes lead to the room name or the names of members in the room being incorrect.

@nico-famedly
fix: state updates being also applied when fetching history
bc33670 
This could sometimes lead to the room name or the names of members in
the room being incorrect.
@nico-famedly nico-famedly requested a review from a team as a code owner June 10, 2024 12:52
td-famedly
td-famedly approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except nitpick

@nico-famedly nico-famedly merged commit fdabed8 into main Jun 10, 2024
14 of 15 checks passed
@nico-famedly nico-famedly deleted the nico/fix-state-updates branch June 10, 2024 13:07
@PhantomRay
Copy link
Contributor

As mentioned in #1772, it's not fixed:

In 0.29.10, it's still not fixed. Just to re-iterate, both of the following are overridden by older events:

  • room name/avatar
  • user name/avatar

@td-famedly td-famedly mentioned this pull request Jul 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@td-famedly td-famedly td-famedly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nico-famedly @PhantomRay @td-famedly