Draft: fix: ensure that direct chat has not more than two members

[famedly-bot]

In GitLab by @h.carnot on Mar 24, 2022, 12:40

Description

Fixes #248

Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I updated/added relevant documentation (doc comments with ///).
• I did not add or update methods, functions or widgets without tests.

[famedly-bot]

In GitLab by @h.carnot on Mar 24, 2022, 12:41

Wouldn't be better to automatically create a new room with only the user that we want to send the verification request to ?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[famedly-bot]

In GitLab by @h.carnot on Mar 24, 2022, 13:50

added 1 commit

• 299c766f - feat: outbound verification request in all case when it has ended

Compare with previous version

[famedly-bot]

In GitLab by @krille-chan on Mar 24, 2022, 13:59

Commented on lib/src/utils/device_keys_list.dart line 92

Hm, but if I have invited a bot to a DM room, why should it be impossible to do a verification in it? 🤔

[famedly-bot]

In GitLab by @h.carnot on Mar 24, 2022, 15:36

Commented on lib/src/utils/device_keys_list.dart line 92

I think it should be fine. Depends on how client are configured to m.key.request, but should be ok.
On contrary to the linked issue, I didn't get any issue while testing.

[famedly-bot]

In GitLab by @h.carnot on Mar 24, 2022, 15:37

marked this merge request as draft

[famedly-bot]

In GitLab by @h.carnot on Apr 27, 2022, 11:44

I will close this is as the linked issue is an open question. Further discussion in the issue is needed.